Upsert method with thing id arg #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hey @Thomasparsley, thank you for your contribution to the surrealdb.net library. This issue should already be resolved in a previous PR, hence why I'll be closing this PR. If you do continue to experience any issues, please let me know 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method for Upsert that accepts
T datain addition toThing id. The existing Upsert method now internally uses the new Upsert method.Task<T> Upsert<T>(Thing id, T data, CancellationToken cancellationToken)The reason behind this PR is that I am using Strong Typed IDs and cannot use the existing Upsert method. I have a
ToThingmethod for each typed id.