Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semaphore extra release. #186

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

EricSites
Copy link
Contributor

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

Fix this bug: #185

What does this change do?

Fixes extra semaphore release when connection is canceled.

What is your testing strategy?

Large system using SurrealDB on TiVK.

Is this related to any issues?

semaphore

Have you read the Contributing Guidelines?

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.17%. Comparing base (6fd2105) to head (b33f878).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   69.65%   73.17%   +3.52%     
==========================================
  Files         161      180      +19     
  Lines        6702     7369     +667     
  Branches      775      764      -11     
==========================================
+ Hits         4668     5392     +724     
+ Misses       1689     1672      -17     
+ Partials      345      305      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kearfy kearfy merged commit 5d00667 into surrealdb:main Mar 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants