dTWAP and dLIMIT integration by Orbs #1550

denis-orbs · 2024-07-16T07:39:55Z

Added dTWAP and dLIMIT pages

images:

PR-Codex overview

The focus of this PR is to introduce support for a new feature called TWAP (Time-Weighted Average Price) in the SushiSwap UI.

Detailed summary

Added keyv to the list of ignored plugins in Webpack configuration
Updated dependencies for @orbs-network/twap-ui-sushiswap and other packages
Added components and logic for TWAP functionality in the SushiSwap UI

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-07-16T07:39:59Z

⚠️ No Changeset found

Latest commit: 7f5f013

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-07-16T07:40:01Z

@denis-orbs is attempting to deploy a commit to the Sushi Team on Vercel.

A member of the Team first needs to authorize it.

apps/web/src/ui/swap/swap-mode-buttons.tsx

apps/web/src/ui/swap/twap.tsx

LufyCZ · 2024-07-16T08:49:19Z

apps/web/src/ui/swap/twap.tsx

+import { SimpleSwapBridgeBanner } from "./simple/simple-swap-bridge-banner";
+
+const LOGO = {
+  [ChainId.BASE]: "ethereum.svg",


LufyCZ · 2024-07-16T08:49:54Z

apps/web/src/ui/swap/twap.tsx

+  return (
+    <Dialog open={open} onOpenChange={() => onClose()}>
+      <DialogContent>
+        {" "}


intentional?

LufyCZ · 2024-07-16T08:50:04Z

apps/web/src/ui/swap/twap.tsx

+  children,
+  onSelect,
+}: {
+  selected: any;


any (guessing Type would work as in the onSelect type?)

LufyCZ · 2024-07-16T09:00:19Z

apps/web/src/ui/swap/twap.tsx

+  };
+};
+
+const usePriceUSD = (address?: string) => {


address should have the Address type from viem

LufyCZ · 2024-07-16T09:01:53Z

apps/web/src/ui/swap/twap.tsx

+
+const useTokenList = () => {
+  const { data: customTokenMap } = useCustomTokens();
+  const chainId = useDerivedStateSimpleSwap().state.chainId;


same as above with the pattern

LufyCZ · 2024-07-16T09:03:31Z

apps/web/src/ui/swap/twap.tsx

+
+  const { data: otherTokenMap } = useOtherTokenListsQuery({
+    chainId,
+    query: "",


ideally query should be optional on useOtherTokenListsQuery, but it's not, think undefined would make more sense than ""

LufyCZ · 2024-07-16T09:04:39Z

apps/web/src/ui/swap/twap.tsx

+    customTokenMap,
+    tokenMap,
+    chainId,
+    balancesMap: {},


balancesMap can be removed

LufyCZ · 2024-07-16T09:06:00Z

apps/web/src/ui/swap/twap.tsx

+};
+
+export const useIsTwapSupported = () => {
+  const { state } = useDerivedStateSimpleSwap();


{ state } -> { state: { chainId } }

LufyCZ · 2024-07-16T09:24:39Z

A couple more things from your screenshots:

not sure why the xswap icon is white here, it's colored in prod

the spacing in the 1 ICON ETH part looks a bit sketchy

would add rounding to the "loading" bar

typo

think we shorten addresses more around the app, would be better if it was consistent

Overall though it's pretty visible in some places that your package doesn't use our UI components, wonder what'd be the best way to address that. We want to eventually release @sushiswap/ui, but probably not in the near future (weeks).

Think ideally all the components would live in our app (under apps/web/src/(evm)/swap/(orbs)/...), where they could import our components. The logic could be imported from your sdk. The annoying thing would be upkeep from your side, I get that keeping everything in your repo is nice.

LufyCZ · 2024-07-19T06:44:00Z

@denis-orbs I've been looking around your packages and the amount of dependencies they use is honestly too excessive. Lodash is not necessary nowadays at all, and importing the whole thing (with import _ from "lodash"), not allowing three-shaking to do its job is even worse. The whole graph is a bit terrifying, and I don't think we can get this merged in before it's cleaned up.

I've spent the whole of June trying to reduce our bundle sizes and managed to get them down to ~800-900KB for /swap:

but after this PR it's immediately up 700KB to 1.6MB:

matthewlilley · 2024-07-22T17:05:33Z

@denis-orbs In an ideal world we'd prefer to have the business logic live inside our repo and make use of our UI component library.

We have concerns with bundle sizes which as Lufy mentioned has been a key focus in the past couple of months, but also with uneccasary dependencies which themselves could have loose dependecies that could pose a secuirty issue down the line, generally we tend to own rather than clone in a lot of cases these days.

socket-security · 2024-07-30T12:20:55Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	filesystem	`0`	93.2 kB	wighawag

🚮 Removed packages: npm/@types/[email protected], npm/[email protected]

View full report↗︎

vercel · 2024-07-30T15:19:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web	❌ Failed (Inspect)			Aug 2, 2024 4:32pm

LufyCZ · 2024-08-02T21:18:09Z

#1582

recreated the PR here, to get all the checks + the deployment to run

matthewlilley requested review from LufyCZ and 0xMasayoshi July 16, 2024 07:40

LufyCZ requested changes Jul 16, 2024

View reviewed changes

denis-orbs closed this Jul 27, 2024

denis-orbs force-pushed the master branch from 8c77c01 to 08ccb44 Compare July 27, 2024 10:33

denis-orbs reopened this Jul 30, 2024

denis-orbs force-pushed the master branch from f0e7970 to 6336694 Compare July 30, 2024 12:19

vercel bot deployed to Preview – web July 30, 2024 15:27 View deployment

denis-orbs closed this Jul 31, 2024

denis-orbs force-pushed the master branch from 6336694 to afc19bb Compare July 31, 2024 13:40

denis-orbs reopened this Jul 31, 2024

vercel bot had a problem deploying to Preview – web August 2, 2024 16:32 Failure

vercel bot deployed to Preview – token-list August 2, 2024 16:34 View deployment

vercel bot had a problem deploying to Preview – tron August 2, 2024 16:34 Failure

vercel bot had a problem deploying to Preview – aptos August 2, 2024 16:35 Failure

vercel bot had a problem deploying to Preview – tokens August 2, 2024 16:35 Failure

denis-orbs closed this Aug 12, 2024

denis-orbs force-pushed the master branch from fecf08a to 7f5f013 Compare August 12, 2024 12:07

dTWAP and dLIMIT integration by Orbs #1550

dTWAP and dLIMIT integration by Orbs #1550

Uh oh!

Conversation

denis-orbs commented Jul 16, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jul 16, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LufyCZ commented Jul 16, 2024

Uh oh!

LufyCZ commented Jul 19, 2024

Uh oh!

matthewlilley commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LufyCZ commented Aug 2, 2024

Uh oh!

Uh oh!

denis-orbs commented Jul 16, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Jul 16, 2024 •

edited

Loading

matthewlilley commented Jul 22, 2024 •

edited

Loading

socket-security bot commented Jul 30, 2024 •

edited

Loading

vercel bot commented Jul 30, 2024 •

edited

Loading