enable tekton support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Yuan <[email protected]>
SamYuan1990
commented
Mar 11, 2024
SamYuan1990
force-pushed
the
supportTekton
branch
from
f8e14f2
to
385a27a
Compare
index.js
Outdated
| @@ -103,6 +104,10 @@ async function setup() { | |||
| core.info(`use grafana enable `+grafana_enable); | |||
| parameterExport = parameterExport + " && export GRAFANA_ENABLE="+grafana_enable; | |||
| } | |||
| if (tekton_enable.length !==0) { | |||
| core.info(`use grafana enable `+tekton_enable); | |||
Signed-off-by: Sam Yuan <[email protected]>
vprashar2929
approved these changes
Mar 11, 2024
|
@SamYuan1990 In another PR, we can add steps to verify tekton installation in |
| @@ -62,19 +62,56 @@ jobs: | |||
| test_local_cluster_with_prometheus_grafana: | |||
There was a problem hiding this comment.
nit: test_local_cluster_with_prometheus_grafana should be test_local_cluster_with_prometheus_grafana_tekton?
I am open for it. but consider sustainable-computing-io/local-dev-cluster#60 (comment) I will merge this PR and give a quick test for sustainable-computing-io/aws_ec2_self_hosted_runner#17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once this PR been merged, let try to use latest branch to integrate with kepler model server.
add tekton support