Skip to content

fix: compatibility with exactOptionalPropertyTypes #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Stadly
Copy link
Contributor

@Stadly Stadly commented Jul 29, 2024

With exactOptionalPropertyTypes enabled, optional properties cannot be undefined unless explicitly allowed. This commit explicitly allows optional properties to be undefined, making Paneforge usable in projects with exactOptionalPropertyTypes enabled.

The issue was discovered when solving huntabyte/bits-ui#516 and melt-ui/melt-ui#1256. Updating bits-ui and melt-ui solved most of the issues when using shadcn-svelte in a project with exactOptionalPropertyTypes enabled. This PR fixes the issues also for Resizable.

With [`exactOptionalPropertyTypes`](https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes) enabled, optional properties cannot be `undefined` unless explicitly allowed. This commit explicitly allows optional properties to be `undefined`, making paneforge usable in projects with `exactOptionalPropertyTypes` enabled.
Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: ae86571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 29, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
paneforge ✅ Ready (View Log) Visit Preview ae86571

Copy link
Member

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit 7d32a24 into svecosystem:main Jul 30, 2024
3 checks passed
@Stadly Stadly deleted the exact-optional-property-types branch July 31, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants