Skip to content

Enhancement: Animation expanding/collapsing - CSS #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2025
Merged

Enhancement: Animation expanding/collapsing - CSS #69

merged 5 commits into from
Apr 2, 2025

Conversation

jaysin586
Copy link
Contributor

Added a new state that can be tracked for CSS transitions.

This should address the issue here: #25

The CSS below is an ugly way to do it in this PR, but it should work with all transition effects:

:global(div[data-pane-state="collapsing"]) {
	transition-duration: 1000ms;
	transition-property: flex-grow;
	transition-timing-function: linear;
	will-change: flex-grow;
}

:global(div[data-pane-state="expanding"]) {
	transition-duration: 1000ms;
	transition-property: flex-grow;
	transition-timing-function: linear;
	will-change: flex-grow;
}

I am open to matching your style, just wanted to start the conversation.

I also did not see any test cases to match your test case style. If you have some other code you would like me to mimic using vitest and/or playwright I can help!

Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: bd63dfb

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 2, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
paneforge ✅ Ready (View Log) Visit Preview bd63dfb

@huntabyte huntabyte merged commit b193237 into svecosystem:next Apr 2, 2025
4 checks passed
This was referenced Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants