Skip to content

Conversation

@xl0
Copy link

@xl0 xl0 commented Dec 20, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2025

⚠️ No Changeset found

Latest commit: a733fc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xl0
Copy link
Author

xl0 commented Dec 20, 2025

I feel this makes the code more explicit an readeable when I want to revert to the default state.
Should also help with #388

@TGlide
Copy link
Member

TGlide commented Dec 20, 2025

Thanks for the PR! #388 has since been closed, but this could be useful.

however one thing that I'm thinking about... @huntabyte we probably should allow setting the state as undefined, no? as in to allow any type of data inside localStorage, instead of being picky about undefined, specially since we allow null

@huntabyte
Copy link
Member

I want to say there was a reason it is the way it is. Will look into the code later to see.

@xl0
Copy link
Author

xl0 commented Dec 23, 2025

For my usecase, I can live with just .reset(). Want me to update the PR to limit to .reset() without touching undefined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants