Remote Functions Exploration PR #13957
Open
+4,946
−350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s different types of remotes
|
| const info = get_remote_info(event); | ||
| const stringified_arg = stringify_remote_arg(arg, info.transport); | ||
| const id = /** @type {RemoteInfo} */ (/** @type {any} */ (wrapper).__).id; | ||
| const url = `${base}/${app_dir}/remote/${id}/${stringified_arg}`; |
There was a problem hiding this comment.
Suggested change
| const url = `${base}/${app_dir}/remote/${id}/${stringified_arg}`; | |
| const url = `${base}/${app_dir}/remote/${id}${stringified_arg ? `/${stringified_arg}` : ''}`; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is full of exploratory commits, changing directions of the implementation multiple times. As such it's of limited use, and it will be squash-merged into the
remote-functionsbranch which can then start from a clean state to iron out bugs, tweak the final design, etc.