fix: ignore missing @opentelemetry/api (#14774)

[james-pre]

This PR ignores errors when @opentelemetry/api is not installed since it is an optional dependency. Fixes #14774.

---

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

• Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

[changeset-bot]

🦋 Changeset detected

Latest commit: c83f9f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[benmccann]

seems okay to me, but we should probably have someone more knowledgeable with TypeScript weigh in

[james-pre]

Given that @ts-ignore won't work, 4e32ec0 stubs the things imported by SvelteKit. pnpm check runs successfully, so this will hopefully fix the problem.

[teemingc]

Given that @ts-ignore won't work, 4e32ec0 stubs the things imported by SvelteKit. pnpm check runs successfully, so this will hopefully fix the problem.

I'm not sure if that will work or if that did anything. Note that you'll have to test against the types found in node_modules/@sveltejs/kit/types/index.d.ts of your project. dts-buddy generates that file via the script in packages/kit/scripts/generate-dts.js.

[james-pre]

Thanks for the tip! I've gone ahead and gotten a solution that results in the error being gone in a local project.

[teemingc]

I've tried this but I think it removes the autocomplete for users when they do have @opentelemetry/api installed since these types then override the actual package.

[james-pre]

It's a trade off. The alternative is that more users can't build at all unless they completely disable type-checking libraries. If there is a way to get autocomplete when it is installed without breaking dependents missing OTEL, I'm all for it.

I've created floating point airthmatic within the type system, yet this somehow is a harder problem...

[teemingc]

I wonder if we should conditionally generate the stub by checking if @opentelemetry/api is installed 😆 otherwise, getting sveltejs/dts-buddy#110 merged would let us use // @ts-ignore even if it's frowned upon in that thread

[james-pre]

I think that being able to use @ts-ignore would be a better and easier solution.

[james-pre]

@teemingc do you have any plans to merge the dts-buddy PR soon? If not I'd like to get this PR merged since it would fix the bug. We could look into using ts-ignore after your PR is merged.

[teemingc]

I'd need another maintainer to approve the dts-buddy PR to merge it. Even then, it seems like all the tests are failing after I've merged the main branch. I'll need to take a look at those. cc: @Rich-Harris

EDIT: we can't merge this PR as is because the stubs here will break the TypeScript autocomplete for users who do have otel installed

[svelte-docs-bot]

Preview: https://svelte-dev-git-preview-kit-14848-svelte.vercel.app/