-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support Cloudflare Workers CI as well as Pages #14871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 39af0a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Happy to add a test here, but there don't seem to be any relevant existing tests for the auto adapter, so I wasn't sure where the best place to add it would be. |
Hi Somhairle, I had some thoughts in #13733 (comment) but basically, we weren't sure how the auto adapter would work if the build would always fail without a properly configured wrangler.jsonc file. At that point, it might make more sense for the user to install the Cloudflare adapter directly. Otherwise, the package.json changes in this PR look useful. |
The SvelteKit auto adapter only checks for
CF_PAGESbefore using the Cloudflare adapter. Instead, it should check forCF_PAGESandWORKERS_CI, since the Cloudflare adapter supports both Workers and Pages .Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits