fix: prevent unused variable error for bindable #2710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2268
I was originally thinking about filtering it out in the language server so that it's easier to only filter out the props that are being reassigned. However, TypeScript combines the diagnostics into one when destructured variables are unused, this route won't work.
As for why the error isn't reliable in the editor, I tried debugging and found that if the symbol is already analysed prior to the diagnostics, the error/hint won't show. So it's a race condition. Our diagnostics are delayed later than TSServer, so it's easier to trigger. (Edit. found a reproduction in ts file and filed a upstream issue)