-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: Enhanced XHTML support #17418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Enhanced XHTML support #17418
Conversation
🦋 Changeset detectedLatest commit: c11d75a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
What is the point of running Svelte on XML pages? It introduces checks and uppercasing which are wasteful for 99.9999999% of users. |
Is it, though? It looks like it requires at least the changes to
The (*) Meaning, the check isn't necessary for the purposes of this PR the same way uppercasing is. If it's certain that elements won't have another namespace, the check is redundant.
Is this question about documents served as If it's regarding XHTML, it's IMHO a valid use-case for the framework, and one that didn't seem too hard to support. To support this, two changes were needed: the change in If it's regarding XML, the answer is less clear, as probably using the correct file type would be preferred. However, again it didn't seem too hard to support (basically, just using |
4f1a6d5 to
8d8de65
Compare
Under "these" I meant the mentioned changes.
I think the user just should set the correct file/content type. Also, you should add to the code comments that those operations are needed for XHTML compliance. |
Closes #16540
Follow up to a86e52b
This PR adds support for using Svelte in XHTML and XML documents by:
requiredbecomesrequired="")tagName/nodeName, as well as ensuring that the values have the correct case.document.createElementwithdocument.createElementNS, defaulting to the HTML namespace. This ensures that even documents loaded in pure XML mode (e.g.,index.xml, as opposed toindex.xhtml) will work correctly.