fix: handle event delegation in custom elements #17497
Draft
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue where handle_event_propagation breaks when delegated events are arrays instead of functions, which can happen in custom elements used across different Svelte versions. Changes: 1. Compiler: Don't delegate events in custom element builds 2. Runtime: Handle both function and array delegates defensively This prevents cross-version compatibility issues with custom elements.
benjosua
force-pushed
the
fix-event-delegation-custom-elements
branch
2 times, most recently
from
1902ae3 to
d6e70b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix issue #17057 where handle_event_propagation breaks when delegated events are arrays instead of functions in custom elements.
Changes:
This prevents cross-version compatibility issues with custom elements.
Not a perfect solution. Is this the most practical path forward, or is there a cleaner approach that allows cross-version compatibility?