fix: await in each block over store re-runs infinitely #17500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17471, fixes #17394
This was happening because
mutable_sourceusessafe_equalswhich always treats objects as different, so the async derived within would always be marked as dirty and re-run.My fix tracks object refs between async derived runs, and skips re-running if they haven't changed. I've included two test samples, as my first pass at this didn't check if we were in the same batch, which broke updating a prop on an object with an unchanged ref. I haven't been able to get the first sample with each to fail because it freezes the test runner instead :) not sure how best to handle that without introducing a timeout feature to the runner.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint