Fix displaying of system messages by default#294
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where system messages were not visible by default in the chat log window. By explicitly setting a flag during initialization, it ensures that users will see system-generated messages without needing to manually enable them, improving the out-of-the-box user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where system messages were not displayed by default due to an uninitialized member variable. The change correctly initializes m_bShowMessages to true in the CNewUISystemLogWindow::Init method, ensuring system messages are shown as intended. My review includes a suggestion to adopt a more modern C++ initialization practice for better code quality and maintainability.
| m_nShowingLines = 6; | ||
| m_iCurrentRenderEndLine = -1; | ||
| m_fBackAlpha = 0.6f; | ||
| m_bShowMessages = true; |
There was a problem hiding this comment.
While this correctly initializes m_bShowMessages and fixes the bug, a more modern C++ approach is to initialize members directly in the constructor's initializer list or, since C++11 features like constexpr are used elsewhere, via in-class member initialization in the header file. This practice ensures all members are initialized before the constructor body executes and centralizes initialization, which improves code clarity and maintainability.
For example, in NewUIChatLogWindow.h:
bool m_bShowMessages = true;
System messages (experience, picked up items) are enabled by default after logging in, but no messages are shown.
This PR fixes the issue.