Skip to content

Fix displaying of system messages by default#294

Open
olisikh wants to merge 1 commit intosven-n:mainfrom
olisikh:bug/system_messages_fix
Open

Fix displaying of system messages by default#294
olisikh wants to merge 1 commit intosven-n:mainfrom
olisikh:bug/system_messages_fix

Conversation

@olisikh
Copy link

@olisikh olisikh commented Mar 18, 2026

System messages (experience, picked up items) are enabled by default after logging in, but no messages are shown.
This PR fixes the issue.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where system messages were not visible by default in the chat log window. By explicitly setting a flag during initialization, it ensures that users will see system-generated messages without needing to manually enable them, improving the out-of-the-box user experience.

Highlights

  • Default System Message Display: Ensured that system messages are displayed by default in the chat log window by initializing the m_bShowMessages flag to true during the window's initialization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where system messages were not displayed by default due to an uninitialized member variable. The change correctly initializes m_bShowMessages to true in the CNewUISystemLogWindow::Init method, ensuring system messages are shown as intended. My review includes a suggestion to adopt a more modern C++ initialization practice for better code quality and maintainability.

m_nShowingLines = 6;
m_iCurrentRenderEndLine = -1;
m_fBackAlpha = 0.6f;
m_bShowMessages = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this correctly initializes m_bShowMessages and fixes the bug, a more modern C++ approach is to initialize members directly in the constructor's initializer list or, since C++11 features like constexpr are used elsewhere, via in-class member initialization in the header file. This practice ensures all members are initialized before the constructor body executes and centralizes initialization, which improves code clarity and maintainability.

For example, in NewUIChatLogWindow.h:

bool m_bShowMessages = true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant