Fix random MU Helper and Location widgets disappearances#295
Fix random MU Helper and Location widgets disappearances#295olisikh wants to merge 1 commit intosven-n:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a persistent bug causing critical UI elements, specifically the MU Helper and Location widgets, to vanish unexpectedly during inventory management. The fix ensures that when the extended inventory interface is hidden, the system correctly triggers all associated side effects, preventing the unintended disappearance of other UI components and improving overall user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the MU Helper and Location widgets would randomly disappear. The fix involves changing how the extended inventory UI is hidden. Instead of directly manipulating its visibility, the code now uses the Hide() method, which correctly handles associated side effects like restoring the hero position widget. This is a good, clean fix that improves code consistency and resolves the described bug.
|
It seems that this bug still happens, would need to give a closer look |
Fixes MU helper randomly disappearing after interacting with stash / inventory, while moving items around extension stashes.