Skip to content

Fix random MU Helper and Location widgets disappearances#295

Draft
olisikh wants to merge 1 commit intosven-n:mainfrom
olisikh:bug/mu_helper_disappearing
Draft

Fix random MU Helper and Location widgets disappearances#295
olisikh wants to merge 1 commit intosven-n:mainfrom
olisikh:bug/mu_helper_disappearing

Conversation

@olisikh
Copy link
Contributor

@olisikh olisikh commented Mar 18, 2026

Fixes MU helper randomly disappearing after interacting with stash / inventory, while moving items around extension stashes.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a persistent bug causing critical UI elements, specifically the MU Helper and Location widgets, to vanish unexpectedly during inventory management. The fix ensures that when the extended inventory interface is hidden, the system correctly triggers all associated side effects, preventing the unintended disappearance of other UI components and improving overall user experience.

Highlights

  • UI Disappearance Fix: Resolved an issue where MU Helper and Location widgets would randomly disappear after interacting with the stash or inventory, particularly when moving items in extension stashes.
  • Interface Hiding Logic: Modified the CNewUISystem::Hide method to use the dedicated Hide() function for INTERFACE_INVENTORY_EXT instead of ShowInterface(..., false). This ensures that all paired side effects, such as restoring the hero position widget, are correctly preserved.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where the MU Helper and Location widgets would randomly disappear. The fix involves changing how the extended inventory UI is hidden. Instead of directly manipulating its visibility, the code now uses the Hide() method, which correctly handles associated side effects like restoring the hero position widget. This is a good, clean fix that improves code consistency and resolves the described bug.

@olisikh
Copy link
Contributor Author

olisikh commented Mar 18, 2026

It seems that this bug still happens, would need to give a closer look

@olisikh olisikh marked this pull request as draft March 18, 2026 23:28
@olisikh olisikh marked this pull request as draft March 18, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant