Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaces commander with native parseArgs #215

Merged
merged 11 commits into from
Aug 24, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Aug 23, 2024

Description

  • replaces commander with native parseArgs
  • removes the cli main entry from the bin folder to src (and to dist after running typestript)

Motivation and Context

commander is a great command line parser parser. It has been a good fit for the state-machine-cat cli. parseArgs, which is part of node:utils, is suitable for simple cli needs. And simple cli needas are what state-machine-cat has. Using parseArgs also reduces state-machine-cat('s cli's) dependencies, which means less to maintain & worry about.

How Has This Been Tested?

  • automated non-regression tests
  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

tsconfig.json Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Aug 24, 2024

Code Climate has analyzed commit 3ce0c3c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 6de8681 into main Aug 24, 2024
7 checks passed
@sverweij sverweij deleted the refactor/replace-commander-with-native-parse-args branch August 24, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant