-
Notifications
You must be signed in to change notification settings - Fork 190
feat: svix bridge-health-endpoint #1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: svix bridge-health-endpoint #1903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution! 🙏🏻
Looks like there's just one small fixup needed and this can merge through.
@svix-onelson the import is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The START_TIME
will only actually be recorded on first use of the health
endpoint. Can you add START_TIME.force();
to the start of async fn run
so we record it at that point?
c356cf8
to
66da4bd
Compare
Done @svix-jplatte |
bee7f36
to
3901787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @CodeMan62 🙏🏻
Thanks for review 🙏 |
* Libs/Python: Bring back the (deprecated) sync `dashboard_access` method, which was accidentally removed in v1.64.1 * Libs/Csharp: The `options` argument to the `SvixClient` initializer is now optional. * Libs/Csharp: The `SvixOptions.BaseUrl` field is deprecated in favor of `SvixOptions.ServerUrl` * Libs/(Ruby and Kotlin): Add doc comments to class attributes * Libs/Go: Added a new `<Enum>From<UnderlyingType>` map to all enums. For example `BackgroundTaskStatusFromString["running"]` will result in `BACKGROUNDTASKSTATUS_RUNNING` * Libs/Go: Fixed bug where the correct `content-type` was not set on `PUT` requests * Bridge: Add `/health` endpoint by @CodeMan62 in #1903 * Server: Add URL validation to operational server webhooks by @CodeMan62 in #1887
Motivation
There is no health enpoint in svix bridge so this PR adds a health endpoint to svix bridge
Solution
Work in progress