Use double quotes consistently #1914
Conversation
svix-mman
force-pushed
the
mendy/consistent-quotes
branch
from
c846aa0 to
2e214b5
Compare
svix-mman
force-pushed
the
mendy/consistent-quotes
branch
from
2e214b5 to
b825695
Compare
There was a problem hiding this comment.
Sort of mirroring Jonas' comment, I would have encouraged us to go single-quote just because it feels safer in CI where shell invocations sometimes happen (and unexpected variable substitution could be unexpected). Single quotes are "safety on" with an explicit escalation to double quotes where needed.
Maybe that's just me?
There was a problem hiding this comment.
cd .github/workflows/
find -type f -name "*.yml" | xargs sed -i "s/\"/'/g"Okie, I may as well get it right 🥲
There was a problem hiding this comment.
nvm, This is going to take more then 5 minutes
There was a problem hiding this comment.
@svix-onelson does your comment block this PR, or can I merge?
There was a problem hiding this comment.
My preference is to just close the PR. I did a quick search under .github/ and there are 108-ish occurrences of " and the majority of them are in places where variable substitution are in play.
There was a problem hiding this comment.
okie, I will close for now
We can always re-open 😉
Don't use a mix of single and double quotes