Mark form parameters as required when body is required

[skrysmanski]

This pull request fixes the problem that when a form request body is marked as "required", then all form parameters should also be marked as "required".

For example, take this (shortened) input spec:

paths:
  /test_required:
    post:
      summary: Operation with form body that is required
      requestBody:
        required: true
        content:
          application/x-www-form-urlencoded:
            schema:
              $ref: '#/components/schemas/Category'

components:
  schemas:
    Category:
      type: object
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string

It results in 2 form parameters (id and name). Without this fix both parameters would be marked as "optional", even though the request body is marked as "required".

[HugoMario]

awesome, thanks !!!

[knoxg]

I think this ticket should be reverted. Just because an object is required does not make all the fields in that object required. I think the problem described above would be better fixed by making the 'id' and 'name' fields required if that's what @skrysmanski was trying to do.

It should always be possible within an object hierarchy to have a required object which contains optional fields, so with that in mind I don't see why making a requestBody required should make the fields in the object of that request also required. The fields that are required should be marked as required, so that it is possible to have a mix of both required and optional fields.

Related tickets where this change has caused problems:

• [PHP] Generator doesn't respect the optional parameters in request body when content type is application/x-www-form-urlencoded swagger-codegen#11129
• Code generation bug in parameters required checking swagger-codegen#9855

This might come down to semantics around what 'required' means on the requestBody, but it seems the interpretation in this PR is wrong, it seems much more likely that OpenAPI would want to support optional fields on required objects. i.e. being able to express that

• a request body is required, but
• some fields within that object are optional and some fields are required

is a use-case that swagger should support.