Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Jackson/@JsonUnwrapped - unwrapping fails when innerModel.$ref not null #4782

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

mironbalcerzak
Copy link
Contributor

@mironbalcerzak mironbalcerzak commented Nov 15, 2024

Issue ticket:
#4781

@mironbalcerzak
Copy link
Contributor Author

CC: @micryc

@mironbalcerzak mironbalcerzak force-pushed the 4781 branch 2 times, most recently from 74b7f5a to b82e212 Compare November 16, 2024 21:17
@T3rm1
Copy link

T3rm1 commented Nov 17, 2024

You should add a test. It's easier to see what you actually fix and might get it merged in faster. Unfortunately there are only two people of the maintainers left who showed very little activity in the past (30 commits in total over the last 6 months). I think the project has been mostly abandoned. There are so many open issues and contributions waiting and both @frantuma and @micryc seem to not care about them.

@mironbalcerzak mironbalcerzak changed the title #4781 Jackson/@JsonUnwrapped - unwrapping fails when innerModel.$ref not null [BUGFIX] Jackson/@JsonUnwrapped - unwrapping fails when innerModel.$ref not null Nov 17, 2024
@mironbalcerzak
Copy link
Contributor Author

@frantuma / @micryc - bump

@mironbalcerzak
Copy link
Contributor Author

@frantuma / @micryc - bump

1 similar comment
@mironbalcerzak
Copy link
Contributor Author

@frantuma / @micryc - bump

@mironbalcerzak
Copy link
Contributor Author

@frantuma / @micryc - bump

@mironbalcerzak
Copy link
Contributor Author

@frantuma / @micryc - bump

@T3rm1 - i am very patient 😂

@mironbalcerzak
Copy link
Contributor Author

@frantuma / @micryc - bump

@mironbalcerzak
Copy link
Contributor Author

@frantuma / @micryc - bump

@nicobelleguic
Copy link

nicobelleguic commented Feb 7, 2025

Hi, we have test this PR on a local version of swagger-core. We had the same issue in the generation of our openApi documentation. @JsonUnwrapped was not rendered in the parent object.

After integrating the PR of @mironbalcerzak, problem disapeared and our documentation is what we expect.

Could you please considered to review this PR and integrate it in a future release ?

Thanks a lot

@mironbalcerzak
Copy link
Contributor Author

@frantuma , @micryc bump

@frantuma frantuma self-requested a review February 19, 2025 14:24
@frantuma frantuma merged commit eb49f3f into swagger-api:master Feb 19, 2025
6 checks passed
@mironbalcerzak mironbalcerzak deleted the 4781 branch February 19, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants