feat: oauth2-redirect accept flow in snake case #4823
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some oauth2 or openIdConnect servers redirect back with flow name in snake case. The previous code accepts only flow name in camel case like
accessCode
orauthorizationCode
, but some oauth2 servers just useauthorization_code
.Motivation and Context
Case mismatch fails openId (OAuth2, authorization_code) authorizations.
How Has This Been Tested?
Tested with both
npm run start
, andnpm run build
then tested with docker.Screenshots (if appropriate):
From the https://editor.swagger.io/ website when I went through openId (OAuth2, authorization_code), with openid served by latest keycloak:
After this commit, tested in both local dev and docker:
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests