Fixes issue 1975: bug in const processing, const values of all types now processable #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
changed the title
spacether
changed the title
spacether
changed the title
spacether
changed the title
|
@frantuma @gracekarina thank you for your work on swagger-parser. |
spacether
commented
Nov 6, 2023
| ObjectNode objNode = mapper.createObjectNode(); | ||
| objNode.put("foo", "bar"); | ||
| objNode.put("baz", "bax"); | ||
| assertEquals(openAPI.getComponents().getSchemas().get("ConstWithObject").getConst(), objNode); |
There was a problem hiding this comment.
Should this be a LinkedHashMap instead?
spacether
commented
Nov 6, 2023
| ObjectNode arrayItem = mapper.createObjectNode(); | ||
| arrayItem.put("foo", "bar"); | ||
| arrayNode.add(arrayItem); | ||
| assertEquals(openAPI.getComponents().getSchemas().get("ConstWithArray").getConst(), arrayNode); |
There was a problem hiding this comment.
Should this be a List or ArrayList instead?
frantuma
force-pushed
the
feat_fixes_const_type
branch
from
78849f1 to
1b1fa85
Compare
|
Thanks! |
|
Thanks you for the review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes const type from String to Object
Per json schema docs, const stores one values of any json schema type
"schema"key: https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/main/tests/draft2020-12/const.json#L6Verification:
If merged, this will close out these issues: