ci: adds additional test cases #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
reviewed
Dec 3, 2024
char0n
reviewed
Dec 3, 2024
char0n
reviewed
Dec 3, 2024
char0n
reviewed
Dec 3, 2024
char0n
reviewed
Dec 3, 2024
baywet
commented
Dec 5, 2024
char0n
added a commit
that referenced
this pull request
Dec 14, 2024
BREAKING CHANGE: drop support for query and fragment being part of path Refs #145
|
@baywet I've create Feel free to issue this (or other) PR again that branch. All assumptions in this draft PR and tests should now be passing in expected manner. |
|
I went ahead with this PR and consolidated the test against the |
char0n
pushed a commit
that referenced
this pull request
Dec 24, 2024
# [2.0.0](v1.7.0...v2.0.0) (2024-12-24) ### Bug Fixes * return support for trailing slash ([b2fa107](b2fa107)) ### Features * align ABNF grammar more with RFC 3986 ([4498f0f](4498f0f)), closes [#145](#145) * align grammar with OpenAPI specification ([fdb67cd](fdb67cd)) ### BREAKING CHANGES * drop support for query and fragment being part of path
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additional test cases are supposed to be a base for discussion.
Everything that are inserted as is: I think the ABNF + parsing logic is correct, it's just adding additional validation. Please double check.
Everything else in a NOTE "block": I think the ANBF + parsing logic is incorrect, please double check. Once we agree my suggestion is to evolve the ABNF and move those cases to the right section.