Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rendering titlebar on bottom #4244

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

janza
Copy link
Contributor

@janza janza commented Jun 10, 2019

This implements part of #883 and similar issue on i3/i3/issues/2747 by adding a command titlebar_position. It accepts two options for now: top and bottom.

I've probably missed some edge cases but would like to know if there's any interest in adding this feature?

@ddevault
Copy link
Contributor

+1

@janza janza force-pushed the titlebar-position branch from be48eb9 to 964bc59 Compare July 1, 2019 22:24
Copy link
Member

@RedSoxFan RedSoxFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is listed as a draft, but here's a few small comments.

@janza janza force-pushed the titlebar-position branch from 964bc59 to cc6ab63 Compare August 30, 2019 23:20
@janza janza force-pushed the titlebar-position branch from cc6ab63 to 5069729 Compare October 16, 2019 17:35
@janza
Copy link
Contributor Author

janza commented Oct 16, 2019

I might need a bit of guidance on this one:

I've implemented rendering of titlebar on the bottom which works OK in cases when border is set to 0.
But with the current implementation I see some rendering issues when there is a border. They appear when resizing the window using mouse, but they are not there when resizing using keyboard shortcuts (or swaymsg).

@janza janza marked this pull request as ready for review October 16, 2019 17:48
@ammgws
Copy link
Contributor

ammgws commented Mar 6, 2020

@janza do you still get those rendering issues?

@janza janza force-pushed the titlebar-position branch from 5069729 to c00822a Compare March 8, 2020 17:42
@janza janza force-pushed the titlebar-position branch from c00822a to a318cef Compare February 24, 2021 23:52
@janza janza force-pushed the titlebar-position branch 3 times, most recently from 58c5eb0 to e00024c Compare May 6, 2021 07:43
@emersion emersion added the enhancement New feature or incremental improvement label Dec 21, 2021
@i2
Copy link

i2 commented Mar 4, 2022

Hi, what is the status of this PR? Thank you!

@janza
Copy link
Contributor Author

janza commented Mar 31, 2022

Hi, I've been running sway with this patch for a while now without issues (AUR sway-titlebar-positioning-git).
I would be interested to hear if there's additional feedback on the code and interest in merging it?

@i2
Copy link

i2 commented May 9, 2022

I'd be very interested if this becomes available on main branch.

@gman0
Copy link

gman0 commented Dec 1, 2022

Hello, any updates on this?

@herkhinah
Copy link

I would love getting this merges although it's rejected by i3. In my setup (my focus is more on the top of the display because that way I can sit more ergonomically) I want the most important information at the top of my screen and the noise like system bar and window titles at the bottom.

@janza janza force-pushed the titlebar-position branch 2 times, most recently from cdc2324 to e77373b Compare May 20, 2023 23:14
@Dazage
Copy link

Dazage commented Jul 21, 2023

I'd love to see this merged as it makes for a cleaner interface whenever the sway bar is positioned at the top of the screen.
Rendering the titlebar for applications at the bottom reduces clutter/"noise" between important information in the sway bar and the application(s) on the screen.

@ShalokShalom
Copy link

sway-titlebar-positioning-git

Can I just install this, and it will work? Or is there some more stuff to do?

@janza janza force-pushed the titlebar-position branch from e77373b to e98e01c Compare August 20, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or incremental improvement
Development

Successfully merging this pull request may close these issues.

10 participants