Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaybar: support StatusNotifierItem ToolTip #5776

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nmschulte
Copy link
Contributor

This is some work I started while investigating tool-tip support for d-bus menu in #5161.

The updates to the d-bus message parsing logic are the most interesting thing here. I've not tested since rebasing but the branch builds and runs but I know it does not fully function because the paint logic is naive. Someone more familiar with the Wayland spec or wlroots should be able to nudge this in the right direction; I think it requires an additional surface like the tray uses for popups.

As well, this isn't the kind of support I was after; not many applications use SNI's ToolTip, and instead I just want to update #5161 to paint the application names and/or (icon) descriptions in bordered boxes when hovering on the icons.

@nmschulte
Copy link
Contributor Author

SNI ToolTip is documented here:
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/#org.freedesktop.statusnotifieritem.tooltip

Note that the wiki documentation for valid HTML markup is malformed and displays misleadingly (the HTML for <img src="" alt="">...</img> is not properly escaped):
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/Markup/
https://lists.freedesktop.org/archives/xdg/2020-October/014402.html

@emersion emersion marked this pull request as draft October 30, 2020 09:01
@emersion
Copy link
Member

emersion commented Oct 30, 2020

Converting to draft since this seems to still be WIP (judging from the last commit message). When it's ready let us know.

@emersion emersion added the enhancement New feature or incremental improvement label Dec 21, 2021
@tinywrkb
Copy link

https://gitlab.freedesktop.org/xdg/xdg-specs/-/issues/84

@nmschulte
Copy link
Contributor Author

https://gitlab.freedesktop.org/xdg/xdg-specs/-/issues/84

I'm happy to report there is much recent movement on this upstream issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or incremental improvement
Development

Successfully merging this pull request may close these issues.

3 participants