tree/container: use L_NONE for parent layout of floating container #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach would also remove the need to check https://github.com/swaywm/sway/blob/master/sway/tree/view.c#L1260-L1262 Not entirely sure if it'd regress anything; I looked over all usages of |
The parent of a floating container is technically the workspace, but it is incorrect to say that the parent layout of a floating container is that of the workspace. For instance, if the workspace layout is tabbed, a floating container should not (and does not) show tab decorations. However, prior to this commit, querying its parent layout would nonetheless return `L_TABBED`. Fixes swaywm#5782.
Xyene
force-pushed
the
fix-scrolling-floating-tabs
branch
from
ceff419 to
1c312c4
Compare
RedSoxFan
reviewed
Nov 3, 2020
RedSoxFan
requested changes
Nov 12, 2020
There was a problem hiding this comment.
I think the only thing this breaks is focus prev|next on floating views. Since i3 does support that functionality, that will need to be fixed before this can get merged.
This does change splitt on a floating view to always be L_VERT, but splith and splitv exist so I think that should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent of a floating container is technically the workspace, but it
is incorrect to say that the parent layout of a floating container is
that of the workspace.
For instance, if the workspace layout is tabbed, a floating container
should not (and does not) show tab decorations. However, prior to this
commit, querying its parent layout would nonetheless return
L_TABBED.Fixes #5782.