feat: Enable swc_ast_unknown for wasm plugin#543
Closed
quininer wants to merge 2 commits intoswc-project:mainfrom
Closed
feat: Enable swc_ast_unknown for wasm plugin#543quininer wants to merge 2 commits intoswc-project:mainfrom
quininer wants to merge 2 commits intoswc-project:mainfrom
Conversation
|
Author
|
Because |
Author
|
I don't have time to push this forward at the moment |
kdy1
pushed a commit
that referenced
this pull request
Nov 24, 2025
This is continuation of #543 Note that: 1. styled jsx plugin depends on swc_ecma_minifier 2. swc_ecma_minifier doesn't adapt swc_ast_unknown yet, thus producing compilation error So for this repo we cannot directly add `rustflags = ["--cfg=swc_ast_unknown"]` to `.cargo/.config.toml`. Instead, we have to manually set this flag for all `cargo build` command in `package.json`. I also add the corresponding `cargo check` in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to configure
swc_ast_unknownto ensure forward compatibility.I haven't tested all the plugins yet, there maybe some unknown variants that need to be handled.