Skip to content

Commit

Permalink
Fix: remove a duplicate code block to prevent unexpected exit from em…
Browse files Browse the repository at this point in the history
…pty `dataset` when using Modal. (#291)
  • Loading branch information
gameofby authored Jan 16, 2025
1 parent 8d56c94 commit 3ad332f
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions swebench/harness/run_evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -550,15 +550,6 @@ def main(
predictions = get_predictions_from_file(predictions_path, dataset_name, split)
predictions = {pred[KEY_INSTANCE_ID]: pred for pred in predictions}

if modal:
# run instances on Modal
if not dataset:
print("No instances to run.")
else:
validate_modal_credentials()
run_instances_modal(predictions, dataset, full_dataset, run_id, timeout)
return

# get dataset from predictions
dataset = get_dataset_from_preds(dataset_name, split, instance_ids, predictions, run_id, rewrite_reports)
full_dataset = load_swebench_dataset(dataset_name, split, instance_ids)
Expand Down

0 comments on commit 3ad332f

Please sign in to comment.