Make run_report
more intuitive when using instance_ids
filter during evaluation
#207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when the
run_report
is reported and saved at the end of an evaluation run, theinstance_ids
filter is being ignored, which can be confusing and causes errors in the report for fields likeerror_ids
and some other things.This PR changes the
make_run_report
function to filter the full dataset considered and compare only againstinstance_ids
instead of the complete dataset's unfiltered ids.It should make it easier to see which ids actually had errors when running, as well as make it easier to understand performance from the
run_report
when using theinstance_ids
filter.