Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run_report more intuitive when using instance_ids filter during evaluation #207

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

carlosejimenez
Copy link
Member

Right now, when the run_report is reported and saved at the end of an evaluation run, the instance_ids filter is being ignored, which can be confusing and causes errors in the report for fields like error_ids and some other things.

This PR changes the make_run_report function to filter the full dataset considered and compare only against instance_ids instead of the complete dataset's unfiltered ids.

It should make it easier to see which ids actually had errors when running, as well as make it easier to understand performance from the run_report when using the instance_ids filter.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (a8df201) to head (312b914).
Report is 4 commits behind head on main.

Files Patch % Lines
swebench/harness/utils.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   58.24%   54.62%   -3.62%     
==========================================
  Files          20       20              
  Lines        1971     1977       +6     
==========================================
- Hits         1148     1080      -68     
- Misses        823      897      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosejimenez carlosejimenez merged commit d8586ed into main Aug 17, 2024
3 checks passed
@john-b-yang john-b-yang deleted the improvement/fix-run-report-instance_ids branch January 13, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant