Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNN class for handling MNIST dataset #129

Closed
wants to merge 4 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 24, 2023

Description

This PR adds a new CNN class in the src/cnn.py file to handle the MNIST dataset. The CNN class is designed to process 28x28 grayscale images and includes two convolutional layers, ReLU activations, max pooling, and two fully connected layers. Additionally, a train_cnn function is implemented to train the CNN using the provided DataLoader.

Summary of Changes

  • Created a new file src/cnn.py to contain the CNN class and training function.
  • Imported necessary PyTorch modules in src/cnn.py.
  • Defined a new class CNN in src/cnn.py that inherits from torch.nn.Module.
  • Implemented the __init__ method in CNN to define the layers of the CNN.
  • Implemented the forward method in CNN to perform the forward pass.
  • Defined a train_cnn function in src/cnn.py to train the CNN using the provided DataLoader.
  • Added docstrings and comments to the CNN class and train_cnn function.
  • Imported the CNN class and train_cnn function in src/main.py.
  • Created an instance of the CNN class in src/main.py.
  • Called the train_cnn function in src/main.py, passing the CNN instance, DataLoader, and number of epochs.

Please review and merge this PR to incorporate the new CNN class for handling the MNIST dataset.

Fixes #9.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 24, 2023

Rollback Files For Sweep

  • Rollback changes to src/main.py
  • Rollback changes to src/cnn.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 24, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a new cnn class that defines AND trains the cnn to handle mnist in cnn.py and import it to main.py
0 participants