Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNN class for MNIST dataset (✓ Sandbox Passed) #164

Closed
wants to merge 4 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Nov 26, 2023

Description

This pull request adds a new CNN class for the MNIST dataset. It also updates the main.py file to use the new CNN class and the train function from the cnn.py file.

Summary

  • Added CNN class in cnn.py file
  • Updated main.py file to use the new CNN class and train function

Fixes #9.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Author

sweep-nightly bot commented Nov 26, 2023

Sandbox Executions

  • Ran sandbox for src/cnn.py. ✓
Sandbox logs for https://github.com/sweepai/evals/commit/6f6638f69035db64be8e1f2cfb81e5288000138e
trunk fmt src/cnn.py || exit 0 1/2 ✓
 ✔ Formatted src/cnn.py
Re-checking autofixed files...


Checked 1 file
✔ No issues
trunk check --fix --filter=-ruff --print-failures src/cnn.py 2/2 ✓
Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 1 linter
  • Ran sandbox for src/main.py. ✓
Sandbox logs for https://github.com/sweepai/evals/commit/efdeda6b44dc8f640ec4dcc257ddf0ed836a5419
trunk fmt src/main.py || exit 0 1/2 ✓
 ✔ Formatted src/main.py
Re-checking autofixed files...

 ✔ Formatted src/main.py
Re-checking autofixed files...


Checked 1 file
✔ No issues
Run trunk upgrade to upgrade 1 linter
trunk check --fix --filter=-ruff --print-failures src/main.py 2/2 ✓
Checked 1 file
✔ No issues
  • Ran sandbox for src/api.py. ✗
Run `src/api.py` through the sandbox.

Copy link
Author

sweep-nightly bot commented Nov 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a new cnn class that defines AND trains the cnn to handle mnist in cnn.py and import it to main.py
0 participants