Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNN class for training MNIST model and import it into main.py #39

Closed
wants to merge 2 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 13, 2023

Description

This PR adds a new CNN class in a new file named cnn.py to handle training a Convolutional Neural Network (CNN) on the MNIST dataset. The CNN class is implemented using PyTorch and includes methods for defining the architecture, training the model, and saving the trained model.

The main.py file has been modified to import the CNN class and use it to train the model on the MNIST dataset. After training, the model is saved as mnist_model.pth.

Summary of Changes

  • Created a new file src/cnn.py to implement the CNN class.
  • Imported necessary modules in cnn.py for PyTorch and torchvision.
  • Defined a new class CNN in cnn.py that inherits from torch.nn.Module.
  • Implemented the __init__ method in CNN class to define the architecture of the CNN.
  • Implemented the forward method in CNN class for the forward pass of the CNN.
  • Implemented the train method in CNN class to train the model on the MNIST dataset.
  • Implemented the save_model method in CNN class to save the trained model.
  • Updated src/main.py to import the CNN class from cnn.py.
  • Created an instance of the CNN class in main.py and trained the model on the MNIST dataset.
  • Saved the trained model as mnist_model.pth in main.py.

Fixes #9.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Rollback Files For Sweep

  • Rollback changes to src/main.py
  • Rollback changes to src/cnn.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@wwzeng1 wwzeng1 closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: add a new cnn class that defines AND trains the cnn to handle mnist in cnn.py and import it to main.py
1 participant