Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒[lldb][ASAN][Swift] Do not use backticks in tests #10025

Conversation

wrotki
Copy link

@wrotki wrotki commented Feb 13, 2025

Backticks prevents emitting proper diagnostics when expression evaluation fails.

Replacing backticks expressions with use of lldb tremporary variables in ASAN lldb Swift test

#10012

(cherry picked from commit 578efae)

Backticks prevents emitting proper diagnostics when expression evaluation fails.

Replacing backticks expressions with use of lldb tremporary variables in ASAN lldb Swift test

#10012
(cherry picked from commit 578efae)
@wrotki wrotki requested a review from adrian-prantl February 13, 2025 20:35
@wrotki wrotki requested a review from a team as a code owner February 13, 2025 20:35
@wrotki wrotki changed the title [lldb][ASAN][Swift] Do not use backticks in tests 🍒[lldb][ASAN][Swift] Do not use backticks in tests Feb 13, 2025
@wrotki
Copy link
Author

wrotki commented Feb 13, 2025

@swift-ci test

@adrian-prantl adrian-prantl merged commit 2fc2e7f into swift/release/6.1 Feb 14, 2025
3 checks passed
@adrian-prantl adrian-prantl deleted the eng/m_borsa/lldb_asan_swift_test_fix_swift_release_6.1 branch February 14, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants