[BoundsSafety][APINotes] Add support for bounds attribute on return v… #10214
Conversation
…alue Previously you could only attach bounds attributes to function parameters. Now return values are also supported, although not yet for ObjectiveC methods. Adds test case for bounds safety API notes in C++, and fixes bug where late parsed bounds attributes on C++ method parameters are parsed twice, due to not being removed from the late attributes list after parsing. rdar://146332875
hnrklssn
requested review from
delcypher,
egorzhdan,
ziqingluo-90,
rapidsna and
patrykstefanski
|
@swift-ci test llvm |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
| @@ -7893,7 +7893,7 @@ void Parser::ParseFunctionDeclarator(Declarator &D, | |||
| StartLoc = LParenLoc; | |||
|
|
|||
| /* TO_UPSTREAM(BoundsSafety) ON */ | |||
| LateParsedAttrList LateParamAttrs(/*PSoon=*/false, | |||
| LateParsedAttrList LateParamAttrs(/*PSoon=*/true, | |||
There was a problem hiding this comment.
I think we need a more detailed explanation of PSoon.
Last time when I made changes in ParseBracketDeclarator, I also toggled the PSoon argument from false to true there. In the case I investigated, setting PSoon to false results in late processing of those attributes after the entire C++ class had been parsed. It was incorrect because those attributes belong to member function parameters. In general, I do not fully understand this flag.
At that time, I also checked all call sites of this constructor. IIRC, with your change here, all call sites will be passing true to PSoon. If this is true, maybe we should consider removing this flag?
There was a problem hiding this comment.
To be honest, my understanding is somewhat shallow also. But basically, not parsing and removing the late attributes in this context will lead to an error when parsed later, after finishing parsing of the C++ class. Calling ParseLexedCAttributeList requires PSoon to be true because of an assert, so I changed it. Since we actually are parsing directly, I don't see why not.
@rapidsna do you have any context to add about whether we still need PSoon?
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
|
@swift-ci please smoke test macos |
|
@swift-ci test linux |
|
@swift-ci test macos |
…alue
Previously you could only attach bounds attributes to function parameters. Now return values are also supported, although not yet for ObjectiveC methods. Adds test case for bounds safety API notes in C++, and fixes bug where late parsed bounds attributes on C++ method parameters are parsed twice, due to not being removed from the late attributes list after parsing.
rdar://146332875