[amtool] (#10231) Prevent pushes if there are uncommitted changes #10232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azharudd
requested changes
Mar 11, 2025
ojhunt
force-pushed
the
users/ojhunt/report-unstaged-changes-mk2
branch
from
e7b56a0 to
478f361
Compare
ojhunt
force-pushed
the
users/ojhunt/report-unstaged-changes-mk2
branch
from
478f361 to
dd2214d
Compare
azharudd
requested changes
Mar 12, 2025
apple-ci/amtool
Outdated
| @@ -327,6 +327,15 @@ def main(): | |||
| except GitError: | |||
| pass | |||
|
|
|||
| # Check if we have any unstaged or uncommitted changes in the tree. | |||
| try: | |||
There was a problem hiding this comment.
git diff-index HEAD returns 0 in either case.
ojhunt
force-pushed
the
users/ojhunt/report-unstaged-changes-mk2
branch
from
c950d76 to
43fca46
Compare
azharudd
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent pushing the resolution if there are any uncommitted changes still in the tree