[lldb] Add summary formatter for Swift Task #10265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change vertically condenses how a `Task` is displayed, by hiding the boolean members (ex `isRunning`) and placing those flags in the summary string. The synthetic formatter continues to expose these (and only these) 4 children: * `address` * `id` * `enqueuePriority` * `children` The flags are pipe (`|`) delimited, matching the format used by `swift-inspect`. This change also removes the `Task`'s `kind` field, which currently relevant only in special cases. See `JobKind` in `MetadataValues.h`.
|
@swift-ci test |
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 15, 2025
| case 1: { | ||
| // TypeMangling for "Swift.UInt64" | ||
| CompilerType uint64_type = | ||
| m_ts->GetTypeFromMangledTypename(ConstString("$ss6UInt64VD")); |
There was a problem hiding this comment.
there is TypeSystem::GetPointersizedIntType(), but generally having a helper to get a uint64 in typesystemswift would make sense.
There was a problem hiding this comment.
It appears this is only in TypeSystemClang, but seems reasonable to add to Swift separately.
| mangledTypenameForTasksTuple(tasks.size()); | ||
| CompilerType tasks_tuple_type = | ||
| m_ts->GetTypeFromMangledTypename(ConstString(mangled_typename)); | ||
| DataExtractor data{tasks.data(), tasks.size() * sizeof(tasks[0]), |
There was a problem hiding this comment.
you're not really dereferencing it, but the access to tasks[0] without checking size() makes me uneasy. Why not just use the type name here?
There was a problem hiding this comment.
I used tasks[0] to avoid hard coding the type – which would leave the potential of skew in future changes (if for example the element of tasks were changed.
I'll refactor this to another way to achieve the same.
I started with Example: And it can look worse (imo) for child tasks: |
|
@swift-ci test |
kastiglione
added a commit
that referenced
this pull request
Mar 19, 2025
This change vertically condenses how a `Task` is displayed, by hiding the boolean
members (ex `isRunning`) and placing those flags in the summary string.
The synthetic formatter continues to expose these (and only these) 4 children:
* `address`
* `id`
* `enqueuePriority`
* `children`
The flags are pipe (`|`) delimited, matching the format used by `swift-inspect`.
Here's an example of output when printing a `Task`:
```
(Task<(), Error>) task = id:2 flags:enqueued|future {
address = 0x14b604490
id = 2
enqueuePriority = .medium
children = {}
}
```
This change also removes the `Task`'s `kind` field, which currently relevant only in
special cases. See `JobKind` in `MetadataValues.h`.
(cherry-picked from commit a7714ed)
kastiglione
added a commit
that referenced
this pull request
Mar 19, 2025
This change vertically condenses how a `Task` is displayed, by hiding the boolean
members (ex `isRunning`) and placing those flags in the summary string.
The synthetic formatter continues to expose these (and only these) 4 children:
* `address`
* `id`
* `enqueuePriority`
* `children`
The flags are pipe (`|`) delimited, matching the format used by `swift-inspect`.
Here's an example of output when printing a `Task`:
```
(Task<(), Error>) task = id:2 flags:enqueued|future {
address = 0x14b604490
id = 2
enqueuePriority = .medium
children = {}
}
```
This change also removes the `Task`'s `kind` field, which currently relevant only in
special cases. See `JobKind` in `MetadataValues.h`.
(cherry-picked from commit a7714ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change vertically condenses how a
Taskis displayed, by hiding the booleanmembers (ex
isRunning) and placing those flags in the summary string.The synthetic formatter continues to expose these (and only these) 4 children:
addressidenqueuePrioritychildrenThe flags are pipe (
|) delimited, matching the format used byswift-inspect.Here's an example of output when printing a
Task:This change also removes the
Task'skindfield, which currently relevant only inspecial cases. See
JobKindinMetadataValues.h.