[lldb][swift] Properly detect async functions with ImplicitClosure demangle nodes #10272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the code that generated the mangled names in this test, and rewrites copy/paste as loops. It also changes how "Node paths" are checked so that more paths may be added.
…nclets These should be peeled off just like ExplicitClosures when considering async functions. There is another location where they must be handled, but its test case is encountering another bug in the demangler, so these will be addressed in a separate commit
These are another variant of "FunctionType".
Implicit closures may be the parent of a closure in the demangling tree, so they must be considered inside `AreFuncletsOfSameAsyncClosure`.
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 17, 2025
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review each commit on its own.
rdar://147035260