Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLVM CI - broken mem-attr.ll test #10328

Closed
wants to merge 1 commit into from

Conversation

guy-david
Copy link

@guy-david guy-david commented Mar 23, 2025

Fixes the broken LLVM test:
https://ci.swift.org/job/pr-apple-llvm-project-llvm-linux/660/execution/node/54/log/?consoleFull

This issue was introduced by the following cherry-pick: #10268 which didn't run the LLVM tests prior to merging.

This PR includes llvm#106816 which technically came before the breaking PR, so it looks slightly different, but should fix CI.

) (llvm#106816)

This reverts commit 66927fb.

Filter functions this applies to, which I initially wanted to do in a
follow up to make reverts easier, but turns out without that it gets
really slow

Fleetbench proto: no significant movement
Fleetbench hashing: no significant movement
Fleetbench libc: no significant movement

2nd stage LLVM build:
https://lab.llvm.org/buildbot/#/builders/55/builds/1765/steps/9/logs/stdio
after this change: 80833.56user 3303.04system
previous build: 78430.21user 3258.04system
@guy-david guy-david requested a review from a team as a code owner March 23, 2025 15:03
@guy-david
Copy link
Author

@swift-ci test llvm

@guy-david guy-david changed the title Fix LLVM test Fix LLVM CI - broken mem-attr.ll test Mar 23, 2025
@guy-david
Copy link
Author

Reverted the problematic commit, reapplying the change via #10330.

@guy-david guy-david closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants