Code actions to convert between computed properties and zero-parameter functions#1562
Conversation
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
I’m so sorry, this PR completely slipped past and I only just saw it again while walking through the list of open PRs. The changes look great to me, would you like to rebase the PR on top of main so we can get it merged? If you don’t have the capacity to work on this anymore, I can also take it over the finish line for you.
And sorry again to reply after over a year.
antigluten
force-pushed
the
code-action-zero-parameter-function
branch
from
6d94f19 to
5000d8b
Compare
antigluten
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
Hey, @ahoppen :) |
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for updating the PR after such a long time. 🙏🏽
|
@swift-ci Please test |
|
@ahoppen, could you help with the pipeline failing? |
|
For macOS you need to run a swift-format on your changes ( |
antigluten
force-pushed
the
code-action-zero-parameter-function
branch
from
5000d8b to
9647dcc
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
3 participants
Resolves #1246
Continuation of swiftlang/swift-syntax#2721