Draft
Conversation
Steelskin
commented
Nov 19, 2024
Steelskin
commented
- Add CXX as a language. This is required to link in the standard library on macOS, which is used by dependencies.
- Set up rpath for the macOS binary. This is necessary to produce a working binary post-installation.
* Add CXX as a language. This is required to link in the standard library on macOS, which is used by dependencies. * Set up rpath for the macOS binary. This is necessary to produce a working binary post-installation.
Member
|
Thanks for the PR. Out of curiosity: What’s your motivation to build SourceKit-LSP using CMake on macOS? |
Author
We are building our own Swift toolchain and would like to share most of the build infrastructure with our existing Windows build, which uses CMake. Specifically, we would like to lower total install size so we are building with shared libraries. |
Author
|
I am temporarily moving this PR to draft as I am changing the installation directories in other repositories. See this comment for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.