Skip to content

Conversation

@compnerd
Copy link
Member

Adjust the install rules to account for the different installation expectations on Windows. DLL files are installed into the bin and import libraries are to be installed in lib.

Adjust the install rules to account for the different installation
expectations on Windows. DLL files are installed into the `bin` and
import libraries are to be installed in `lib`.
@compnerd
Copy link
Member Author

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented Nov 24, 2025

We only use these libraries using LoadLibraryW, should it still be installed to bin? Also, in case you didn’t, could you check that we pick up the plugin from the new installation location by checking if we still receive code completion results with the SourceKit plugin in the new location?

@compnerd
Copy link
Member Author

compnerd commented Nov 24, 2025

We only use these libraries using LoadLibraryW, should it still be installed to bin? Also, in case you didn’t, could you check that we pick up the plugin from the new installation location by checking if we still receive code completion results with the SourceKit plugin in the new location?

Well, all the DLLs are meant to be in bin. It really doesn't matter how you use them. That said, it seems that the installer still put them into bin, just did so in the installer.

This PR is paired with swiftlang/swift-installer-scripts#485 and you will see that only the source is changed, not the destination.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. Looks good to me 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants