Add a command plugin which validates the cmake based build #256
Conversation
| } | ||
|
|
||
| extension Process { | ||
| func run() async throws { |
There was a problem hiding this comment.
Thank you for not using waitUntilExit() :)
|
Other than cloning the repos, is there any other setup needed to run this script? Or does modern CMake come with all the Swift support built in and ready to go these days? |
|
Cloning with update_checkout is basically the only prerequisite, but this script has a bunch of small bugs and issues that need to be addressed as well |
Can you add that information as part of the command's help info or in comments? |
owenv
force-pushed
the
owenv/cmake-plugin
branch
from
822c28a to
83f5a82
Compare
owenv
force-pushed
the
owenv/cmake-plugin
branch
from
83f5a82 to
5ded24f
Compare
|
This is good enough to serve as a smoke test of the CMake build on macOS now, I think I'll land it and improve the rest of the platform support over time |
owenv
requested review from
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
|
Should we query the package model from |
|
@swift-ci test macOS |
|
@neonichu I'm not sure if the context API gives us a way to determine what platforms each dependency is used on |
|
I think it's fine to merge either way, but this seems like a prime use case for the API, so if anything is missing that could be good candidates for evolution of plugins. |
This is very very WIP, but it might be worth building out into a script we can use to smoke test the CMake build