Fix copy paste code error: allocate and assign to value #5343
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@parkera I know you don't do this normally, but you may want to fix this bug in Apple's corefoundation too. |
AZero13
changed the title
compnerd
approved these changes
Jan 3, 2026
Member
|
@swift-ci please test |
Contributor
Author
|
@parkera It passed! |
etcwilde
reviewed
Jan 5, 2026
Member
etcwilde
left a comment
etcwilde
left a comment
There was a problem hiding this comment.
Nice catch. Seems like something that should have a test.
I could be missing it, but I don't actually see where this is getting called or exposed.
Contributor
Author
Probably why this bug wasn't caught for the 26? Years this code shipped assuming it was when OS X did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mean to assign to value, not key