[6.1] Fix regression with edge case where navigator may display wrong data #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mportiz08
commented
Jan 29, 2025
mportiz08
commented
- Explanation: Fixes regression where navigator may display wrong tree when provided multiple options from Index JSON
- Scope: Impacts the sidebar navigator in rare cases
- Issue: rdar://140370212
- Risk: Low, small additional code change to make preferred choice when provided multiple trees of data
- Testing: Unit tests added, manually tested with problematic content and existing content without problematic content
- Reviewer: Hanqing Huang
- Original PR: Fix regression with edge case where navigator may display wrong data #916
…wiftlang#916) This addresses a rare edge case where the Index JSON contains multiple top-level root nodes for distinct trees of navigation data. While that shouldn't normally happen in practice, we would like to prefer the tree with a containing module if available instead of always using the first tree provided in the array. Resolves: rdar://140370212
This was referenced Jan 29, 2025
franklinsch
approved these changes
Jan 29, 2025
eango
approved these changes
Jan 29, 2025
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.