[6.2] Fix crash when subheading is clicked on ObjC page #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mportiz08
commented
Jul 2, 2025
mportiz08
commented
- Explanation: Fixes issue where clicking a link to a target on the same page of an Objective-C API may crash the renderer.
- Scope: Impacts DocC generated API symbol pages with ObjC variants that have links to fragment identifiers.
- Issue: rdar://154225522
- Risk: Low, single addition to conditional for specific kinds of pages
- Testing: Added unit tests, manually tested that jumping between sections of an ObjC symbol page doesn't crash anymore and there are no regressions switching between Swift/ObjC pages.
- Reviewer: @marinaaisa
- Original PR: Fix crash when subheading is clicked on ObjC page #951
Example of broken flow: /documentation/foo /documentation/foo?language=objc /documentation/foo?language=objc#bar # may crash when link clicked When a user clicks a subheading link on an Objective-C variant of a page, it may crash because the renderer is mistakenly attempting to apply the patch with ObjC data a second time, which it doesn't need to. Resolves: rdar://154225522
eango
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.