Get the right data when the navigator has multiple top-level roots and multiple languages #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the use cases of navigators with multiple top-level root, we want to make sure that queries don't interfere with the election of the top-level root node when extracting the root node. Before we were reading the window.location.href, which includes queries. Now, by using the window.location.pathname, we ignore the queries, which makes possible to compare with the node.path value to find which it's the correct top-level root. Example: URL: 'http://localhost:8080/documentation/foo?language=objc' Navigator path: '/documentation/foo' By using `window.location.pathname` we ignore `?language=objc` and we can compare `/documentation/foo` with `/documentation/foo`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #158778571, if applicable:
Summary
In the use cases of navigators with multiple top-level root and multiple languages, we want to make sure that the URL queries that are added in different languages don't interfere with the election of the top-level root node.
Before, we were reading the
window.location.href, which includes queries. Now, by using thewindow.location.pathnameproperty, we ignore the queries, which makes possible to compare with thenode.pathvalue to find which it's the correct top-level root.Example: URL:
http://localhost:8080/documentation/foo?language=objcNavigator path:
/documentation/fooBy using
window.location.pathnamewe ignore?language=objcand we can compare/documentation/foowith/documentation/fooDependencies
NA
Testing
Steps:
.doccarchivethat has a navigator with multiple top-level roots and multiple languages (Swift, Obj-C)Checklist
npm test, and it succeeded