Re-enable previously failing bystander module test #1363
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I started a cross-repo test in swiftlang/swift#84510 (comment) to see if this dependency issue has been resolved or not. |
Contributor
Author
|
The Linux and macOS cross-repo tests passed over night. The Windows cross-repo tests seemingly haven't started, waiting for a node to become available to run it, after 17+ hours. I think that means that it's safe for us to re-enable this test again. |
d-ronnqvist
changed the title
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://159615046
Summary
This re-enables a test that was disabled because it failed in the CI. IIRC the issue was out of sync DocC and SymbolKit versions.
AFAICT based on this cross-repo CI test this issue is resolved and we this test can be added back again.
Dependencies
None
Testing
Nothing in particular. This is a test-only change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
AddedUpdated tests./bin/testscript and it succeeded[ ] Updated documentation if necessary