Include linker generated symbol in default defined set #9416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-grumberg
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci please test |
FranzBusch
reviewed
Nov 25, 2025
|
|
||
| package init() { | ||
| self.defined = [] | ||
| self.defined = ["_GLOBAL_OFFSET_TABLE_"] |
Member
There was a problem hiding this comment.
Can we leave a comment here why we include this?
Contributor
Author
There was a problem hiding this comment.
I have since found a bit more information about this. The PR has been updated to point to lld's source code (which provides a list of automatically defined symbols) as well as using the full list to avoid issues in the future hopefully.
daniel-grumberg
force-pushed
the
dgrumberg/reserved-symbols
branch
from
fe2758b to
c60c8ec
Compare
It seems like `_GLOBAL_OFFSET_TABLE_` is defined by the linker without being present in any object file on x86_64. There are a few other symbols that the linker automatically defines although we haven't run into issues with them. I am including the full list I gathered from lld's source code [1] by default. [1] https://github.com/llvm/llvm-project/blob/177e38286cd61a7b5a968636e1f147f128dd25a2/lld/ELF/Config.h#L632
daniel-grumberg
force-pushed
the
dgrumberg/reserved-symbols
branch
from
c60c8ec to
d0e8fed
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Errors here seem unrelated... |
FranzBusch
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like
_GLOBAL_OFFSET_TABLE_is defined by the linker without being present in any object file on x86_64.