Replace --ignore-if-missing with local file check
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
Feb 14, 2025
Sources/SwiftSDKGenerator/Generator/SwiftSDKGenerator+Copy.swift
Outdated
Show resolved
Hide resolved
- optional is also a keyword
|
@swift-ci test |
MaxDesiatov
changed the title
--ignore-if-missing with local file check
|
@swift-ci test |
MaxDesiatov
approved these changes
Feb 25, 2025
|
I did confirm this works fine on my MacBook Pro, but would be good to double check on another machine as well :) |
|
Oops my bad. I updated the description. The PR is against #181 so I just fat fingered the description. |
euanh
approved these changes
Feb 25, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #181.
Tested this locally by building SDKs. It works for building the SDK for armv7 using my build artifacts:
And also building an SDK for aarch64 using official swift.org artifacts:
@MaxDesiatov @euanh